Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/qemu: read modprobe path from distro package #1656

Merged
merged 1 commit into from
Jun 29, 2023
Merged

providers/qemu: read modprobe path from distro package #1656

merged 1 commit into from
Jun 29, 2023

Conversation

bgilbert
Copy link
Contributor

No description provided.

@bgilbert bgilbert requested a review from prestist June 28, 2023 08:14
@bgilbert bgilbert mentioned this pull request Jun 29, 2023
36 tasks
Copy link
Collaborator

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for doing this;

I assume that the distro based modprobe has better compatibility and function since its for that distro?

@bgilbert
Copy link
Contributor Author

I assume that the distro based modprobe has better compatibility and function since its for that distro?

By default it's the exact same program, called through the exact same path, but this change lets the distro override the path at compile time. Probably no one actually needs this, but it ensures we consistently use the existing mechanism.

@bgilbert bgilbert enabled auto-merge June 29, 2023 19:35
@bgilbert bgilbert merged commit 1b8e8ef into coreos:main Jun 29, 2023
@bgilbert bgilbert deleted the modprobe branch June 29, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants